Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency_mode parameter to aws_cloudformation_stack_set_instance #38498

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Add concurrency_mode parameter to aws_cloudformation_stack_set_instance #38498

merged 3 commits into from
Jul 24, 2024

Conversation

nkraemer-sysdig
Copy link
Contributor

Description

Introduces a concurrency_mode argument within the operation_preferences argument block of the aws_cloudformation_stack_set_instance resource

Relations

Closes #38496

References

Output from Acceptance Testing

% make testacc TESTS=TestAccCloudFormationStackSetInstance_operationPreferences PKG=cloudformation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSetInstance_operationPreferences'  -timeout 360m
=== RUN   TestAccCloudFormationStackSetInstance_operationPreferences
=== PAUSE TestAccCloudFormationStackSetInstance_operationPreferences
=== CONT  TestAccCloudFormationStackSetInstance_operationPreferences
--- PASS: TestAccCloudFormationStackSetInstance_operationPreferences (62.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation     66.571s

@nkraemer-sysdig nkraemer-sysdig requested a review from a team as a code owner July 23, 2024 23:21
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XS Managed by automation to categorize the size of a PR. labels Jul 23, 2024
github-actions[bot]
github-actions bot reviewed Jul 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nkraemer-sysdig 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit self-assigned this Jul 24, 2024
ewbankkit
ewbankkit approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFormationStackSetInstance_operationPreferences\|TestAccCloudFormationStackSetInstance_concurrencyMode\|TestAccCloudFormationStackSetInstance_basic' PKG=cloudformation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/cloudformation/... -v -count 1 -parallel 20  -run=TestAccCloudFormationStackSetInstance_operationPreferences\|TestAccCloudFormationStackSetInstance_concurrencyMode\|TestAccCloudFormationStackSetInstance_basic -timeout 360m
=== RUN   TestAccCloudFormationStackSetInstance_basic
=== PAUSE TestAccCloudFormationStackSetInstance_basic
=== RUN   TestAccCloudFormationStackSetInstance_operationPreferences
=== PAUSE TestAccCloudFormationStackSetInstance_operationPreferences
=== RUN   TestAccCloudFormationStackSetInstance_concurrencyMode
=== PAUSE TestAccCloudFormationStackSetInstance_concurrencyMode
=== CONT  TestAccCloudFormationStackSetInstance_basic
=== CONT  TestAccCloudFormationStackSetInstance_operationPreferences
=== CONT  TestAccCloudFormationStackSetInstance_concurrencyMode
--- PASS: TestAccCloudFormationStackSetInstance_basic (70.34s)
--- PASS: TestAccCloudFormationStackSetInstance_concurrencyMode (76.35s)
--- PASS: TestAccCloudFormationStackSetInstance_operationPreferences (77.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	82.776s

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 24, 2024
@ewbankkit
Copy link
Contributor

@nkraemer-sysdig Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit de20ac9 into hashicorp:main Jul 24, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 24, 2024
@nkraemer-sysdig nkraemer-sysdig deleted the stackset_concurrency_mode branch July 24, 2024 14:55
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.60.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support ConcurrencyMode on CloudFormation StackSet Instances
2 participants
@nkraemer-sysdig @ewbankkit